From: Niels Möller <nisse@lysator.liu.se>
Date: Fri, 21 Sep 2012 18:18:58 +0000 (+0200)
Subject: pbkdf2: Reorganized loops.
X-Git-Tag: nettle_2.6_release_20130116~51
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3eff4cc8c5c7bc1a5569453ef312ed7afb1d11c6;p=thirdparty%2Fnettle.git

pbkdf2: Reorganized loops.
---

diff --git a/ChangeLog b/ChangeLog
index 05c463c4..6dbb80ff 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2012-09-21  Niels Möller  <nisse@lysator.liu.se>
 
+	* pbkdf2.c (pbkdf2): assert that iterations > 0. Reorganized
+	loops.
+
 	* nettle.texinfo (Cipher functions): Stress that the salsa20 hash
 	function is not suitable as a general hash function.
 
diff --git a/pbkdf2.c b/pbkdf2.c
index 3d8a0937..10e6bc20 100644
--- a/pbkdf2.c
+++ b/pbkdf2.c
@@ -5,7 +5,7 @@
 
 /* nettle, low-level cryptographics library
  *
- * Copyright (C) 2012 Simon Josefsson
+ * Copyright (C) 2012 Simon Josefsson, Niels Möller
  *
  * The nettle library is free software; you can redistribute it and/or modify
  * it under the terms of the GNU Lesser General Public License as published by
@@ -48,47 +48,44 @@ pbkdf2 (void *mac_ctx,
   TMP_DECL(U, uint8_t, NETTLE_MAX_HASH_DIGEST_SIZE);
   TMP_DECL(T, uint8_t, NETTLE_MAX_HASH_DIGEST_SIZE);
   
-  unsigned int u;
-  unsigned int l;
-  unsigned int r;
-  unsigned int i;
-  char tmp[4];
+  unsigned i;
 
-  if (iterations == 0)
-    return;
+  assert (iterations > 0);
 
   if (length == 0)
     return;
 
-  l = ((length - 1) / digest_size) + 1;
-  r = length - (l - 1) * digest_size;
-
   TMP_ALLOC (U, digest_size);
   TMP_ALLOC (T, digest_size);
 
-  for (i = 1; i <= l; i++)
+  for (i = 1;;
+       i++, dst += digest_size, length -= digest_size)
     {
-      memset (T, 0, digest_size);
-
-      for (u = 1; u <= iterations; u++)
+      uint8_t tmp[4];
+      uint8_t *prev;
+      unsigned u;
+      
+      WRITE_UINT32 (tmp, i);
+      
+      update (mac_ctx, salt_length, salt);
+      update (mac_ctx, sizeof(tmp), tmp);
+      digest (mac_ctx, digest_size, T);
+
+      prev = T;
+      
+      for (u = 1; u < iterations; u++, prev = U)
 	{
-	  if (u == 1)
-	    {
-	      WRITE_UINT32 (tmp, i);
-
-	      update (mac_ctx, salt_length, salt);
-	      update (mac_ctx, 4, tmp);
-	    }
-	  else
-	    {
-	      update (mac_ctx, digest_size, U);
-	    }
-
+	  update (mac_ctx, digest_size, prev);
 	  digest (mac_ctx, digest_size, U);
 
 	  memxor (T, U, digest_size);
 	}
 
-      memcpy (dst + (i - 1) * digest_size, T, i == l ? r : digest_size);
+      if (length <= digest_size)
+	{
+	  memcpy (dst, T, length);
+	  return;
+	}
+      memcpy (dst, T, digest_size);
     }
 }