From: Julian Seward <jseward@acm.org>
Date: Tue, 24 Aug 2004 22:45:30 +0000 (+0000)
Subject: Comment only change: note an example where better code could have
X-Git-Tag: svn/VALGRIND_3_0_1^2~1129
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3f1f965e2f8baf14ea062d484cdba35dfe5c0f17;p=thirdparty%2Fvalgrind.git

Comment only change: note an example where better code could have
been generated (from md5sum iirc)


git-svn-id: svn://svn.valgrind.org/vex/trunk@205
---

diff --git a/VEX/priv/host-x86/isel.c b/VEX/priv/host-x86/isel.c
index bc16186d67..154c538742 100644
--- a/VEX/priv/host-x86/isel.c
+++ b/VEX/priv/host-x86/isel.c
@@ -337,6 +337,23 @@ static HReg iselIntExpr_R ( ISelEnv* env, IRExpr* e )
          addInstr(env, X86Instr_Alu32R(aluOp, rmi, dst));
          return dst;
       }
+      /* Could do better here; forcing the first arg into a reg
+         isn't always clever.
+         -- t70 = Xor32(And32(Xor32(LDle:I32(Add32(t41,0xFFFFFFA0:I32)),
+                        LDle:I32(Add32(t41,0xFFFFFFA4:I32))),LDle:I32(Add32(
+                        t41,0xFFFFFFA8:I32))),LDle:I32(Add32(t41,0xFFFFFFA0:I32)))
+            movl 0xFFFFFFA0(%vr41),%vr107
+            movl 0xFFFFFFA4(%vr41),%vr108
+            movl %vr107,%vr106
+            xorl %vr108,%vr106
+            movl 0xFFFFFFA8(%vr41),%vr109
+            movl %vr106,%vr105
+            andl %vr109,%vr105
+            movl 0xFFFFFFA0(%vr41),%vr110
+            movl %vr105,%vr104
+            xorl %vr110,%vr104
+            movl %vr104,%vr70
+      */
 
       /* Perhaps a shift op? */
       switch (e->Iex.Binop.op) {