From: Simon McVittie Date: Tue, 14 Nov 2017 14:11:25 +0000 (+0000) Subject: Windows autolaunch: Turn stdout spam into stderr spam X-Git-Tag: dbus-1.13.0~105 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3f3498c9c2026546d15227f6a154a2d38d9124e5;p=thirdparty%2Fdbus.git Windows autolaunch: Turn stdout spam into stderr spam This is still not how warnings and diagnostics should be done (the advice should probably be included in the DBusError) but at least this way it won't interfere with machine-readable output on stdout. See also https://bugs.freedesktop.org/show_bug.cgi?id=103756 Reviewed-by: Philip Withnall [smcv: Added a reference to #103756] Signed-off-by: Simon McVittie Bug: https://bugs.freedesktop.org/show_bug.cgi?id=103601 --- diff --git a/dbus/dbus-sysdeps-win.c b/dbus/dbus-sysdeps-win.c index 980b431e3..90a55a7c0 100644 --- a/dbus/dbus-sysdeps-win.c +++ b/dbus/dbus-sysdeps-win.c @@ -3082,8 +3082,8 @@ _dbus_get_autolaunch_address (const char *scope, DBusString *address, { dbus_set_error_const (error, DBUS_ERROR_FAILED, "could not find dbus-daemon executable"); retval = FALSE; - printf ("please add the path to %s to your PATH environment variable\n", daemon_name); - printf ("or start the daemon manually\n\n"); + fprintf (stderr, "please add the path to %s to your PATH environment variable\n", daemon_name); + fprintf (stderr, "or start the daemon manually\n\n"); goto out; } _dbus_verbose( "found dbus daemon executable at %s",dbus_module_path);