From: Nicholas Nethercote <njn@valgrind.org>
Date: Fri, 22 May 2009 07:09:03 +0000 (+0000)
Subject: DARWIN sync: comment and braces.
X-Git-Tag: svn/VALGRIND_3_5_0~615
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3f5f690a32afed135ca3bf5fb258211369ebe232;p=thirdparty%2Fvalgrind.git

DARWIN sync: comment and braces.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10102
---

diff --git a/coregrind/m_syswrap/syswrap-generic.c b/coregrind/m_syswrap/syswrap-generic.c
index 3290785b1b..ffce2923c8 100644
--- a/coregrind/m_syswrap/syswrap-generic.c
+++ b/coregrind/m_syswrap/syswrap-generic.c
@@ -1180,9 +1180,13 @@ Bool ML_(fd_allowed)(Int fd, const Char *syscallname, ThreadId tid, Bool isNewFd
       VG_(message)(Vg_UserMsg, 
          "Warning: invalid file descriptor %d in syscall %s()",
          fd, syscallname);
-      if (fd == VG_(clo_log_fd))
+      if (fd == VG_(clo_log_fd)) {
 	 VG_(message)(Vg_UserMsg, 
             "   Use --log-fd=<number> to select an alternative log fd.");
+      }
+      // DDD: consider always printing this stack trace, it's useful.
+      // Also consider also making this a proper core error, ie.
+      // suppressible and all that.
       if (VG_(clo_verbosity) > 1) {
          VG_(get_and_pp_StackTrace)(tid, VG_(clo_backtrace_size));
       }