From: Shwetha K Acharya <Shwetha.K.Acharya@ibm.com>
Date: Wed, 29 Oct 2025 11:12:47 +0000 (+0530)
Subject: vfs_streams_xattr: Fix CID 1667321 REVERSE_INULL
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3f82b8530a295feeba3940fbab8ac218debdd1e6;p=thirdparty%2Fsamba.git

vfs_streams_xattr: Fix CID 1667321 REVERSE_INULL

Remove NULL check for fsp. A NULL fsp is a fatal error
that should never occur in this context.

Signed-off-by: Shwetha K Acharya <Shwetha.K.Acharya@ibm.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>

Autobuild-User(master): Anoop C S <anoopcs@samba.org>
Autobuild-Date(master): Wed Oct 29 14:43:28 UTC 2025 on atb-devel-224
---

diff --git a/source3/modules/vfs_streams_xattr.c b/source3/modules/vfs_streams_xattr.c
index 9eb2d0068b5..f892bc45c66 100644
--- a/source3/modules/vfs_streams_xattr.c
+++ b/source3/modules/vfs_streams_xattr.c
@@ -419,9 +419,6 @@ static int streams_xattr_get_ea_value_fsp(
 	ssize_t sizeret;
 	bool refuse;
 
-	if (fsp == NULL) {
-		return EINVAL;
-	}
 	refuse = refuse_symlink_fsp(fsp);
 	if (refuse) {
 		return EACCES;