From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Wed, 31 Jul 2024 01:31:02 +0000 (+1200)
Subject: dsdb:util: dsdb_module_dn initialises on failure
X-Git-Tag: tdb-1.4.13~1265
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3f83d029dea02798612403c52042ec11003e3d92;p=thirdparty%2Fsamba.git

dsdb:util: dsdb_module_dn initialises on failure

I think this may be a root cause of some Coverity false positives.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <josutton@catalyst.net.nz>
---

diff --git a/source4/dsdb/samdb/ldb_modules/util.c b/source4/dsdb/samdb/ldb_modules/util.c
index b343828d508..df70c8ed886 100644
--- a/source4/dsdb/samdb/ldb_modules/util.c
+++ b/source4/dsdb/samdb/ldb_modules/util.c
@@ -887,6 +887,7 @@ int dsdb_module_reference_dn(struct ldb_module *module, TALLOC_CTX *mem_ctx, str
 	ret = dsdb_module_search_dn(module, mem_ctx, &res, base, attrs,
 	                            DSDB_FLAG_NEXT_MODULE | DSDB_SEARCH_SHOW_EXTENDED_DN, parent);
 	if (ret != LDB_SUCCESS) {
+		*dn = NULL;
 		return ret;
 	}