From: Raymond Hettinger <python@rcn.com>
Date: Sun, 18 Apr 2010 23:05:22 +0000 (+0000)
Subject: Issue 8436: set.__init__ accepts keyword args
X-Git-Tag: v3.2a1~1105
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3fb156caa4373e90d1e853f03dc58151ad9ffec8;p=thirdparty%2FPython%2Fcpython.git

Issue 8436: set.__init__ accepts keyword args
---

diff --git a/Lib/test/test_set.py b/Lib/test/test_set.py
index 1e0a909c0a05..627c48c51b4e 100644
--- a/Lib/test/test_set.py
+++ b/Lib/test/test_set.py
@@ -48,6 +48,7 @@ class TestJointOps(unittest.TestCase):
 
     def test_new_or_init(self):
         self.assertRaises(TypeError, self.thetype, [], 2)
+        self.assertRaises(TypeError, set().__init__, a=1)
 
     def test_uniquification(self):
         actual = sorted(self.s)
diff --git a/Objects/setobject.c b/Objects/setobject.c
index 944744183c19..aaa483878e64 100644
--- a/Objects/setobject.c
+++ b/Objects/setobject.c
@@ -1978,6 +1978,8 @@ set_init(PySetObject *self, PyObject *args, PyObject *kwds)
 
 	if (!PyAnySet_Check(self))
 		return -1;
+	if (PySet_Check(self) && !_PyArg_NoKeywords("set()", kwds))
+		return -1;
 	if (!PyArg_UnpackTuple(args, Py_TYPE(self)->tp_name, 0, 1, &iterable))
 		return -1;
 	set_clear_internal(self);