From: Volker Lendecke <vl@samba.org>
Date: Sat, 14 Jun 2008 22:22:47 +0000 (+0200)
Subject: Fix an uninitialized variable found by the IBM checker
X-Git-Tag: samba-4.0.0alpha6~801^2~1048
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3fde7f5979fdf3f72df330a0c6977f677cca8a30;p=thirdparty%2Fsamba.git

Fix an uninitialized variable found by the IBM checker

BAIL_ON_PTR_ERROR jumps to done: which will access extra_data before it's
initialized.

Stefan, please check!

Volker
(cherry picked from commit b59636f78d351ed6d52c4a9fdccdb7850388526c)
(This used to be commit 5663587e5e4703f9e3ff6d78d1f3248053ccd4c0)
---

diff --git a/source3/nsswitch/libwbclient/wbc_pwd.c b/source3/nsswitch/libwbclient/wbc_pwd.c
index d23c378b5fd..b5f167369ca 100644
--- a/source3/nsswitch/libwbclient/wbc_pwd.c
+++ b/source3/nsswitch/libwbclient/wbc_pwd.c
@@ -394,16 +394,16 @@ wbcErr wbcGetGroups(const char *account,
 	uint32_t i;
 	gid_t *groups = NULL;
 
-	if (!account) {
-		wbc_status = WBC_ERR_INVALID_PARAM;
-		BAIL_ON_WBC_ERROR(wbc_status);
-	}
-
 	/* Initialize request */
 
 	ZERO_STRUCT(request);
 	ZERO_STRUCT(response);
 
+	if (!account) {
+		wbc_status = WBC_ERR_INVALID_PARAM;
+		BAIL_ON_WBC_ERROR(wbc_status);
+	}
+
 	/* Send request */
 
 	strncpy(request.data.username, account, sizeof(request.data.username)-1);