From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Thu, 19 Oct 2017 13:28:08 +0000 (+0200)
Subject: Revert "tty: goldfish: Fix a parameter of a call to free_irq"
X-Git-Tag: v4.4.94~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=401231d063c5b362428b80739896a5ee8513d8c5;p=thirdparty%2Fkernel%2Fstable.git

Revert "tty: goldfish: Fix a parameter of a call to free_irq"

This reverts commit 01b3db29ba1edd79b9c3e7cd294739b70257d278 which is
commit 1a5c2d1de7d35f5eb9793266237903348989502b upstream.

Ben writes:
	This fixes a bug introduced in 4.6 by commit 465893e18878 "tty:
	goldfish: support platform_device with id -1".  For earlier
	kernel versions, it *introduces* a bug.

So let's drop it.

Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
---

diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c
index e04b57f79df82..0f82c0b146f6d 100644
--- a/drivers/tty/goldfish.c
+++ b/drivers/tty/goldfish.c
@@ -293,7 +293,7 @@ static int goldfish_tty_probe(struct platform_device *pdev)
 	return 0;
 
 err_tty_register_device_failed:
-	free_irq(irq, qtty);
+	free_irq(irq, pdev);
 err_request_irq_failed:
 	goldfish_tty_current_line_count--;
 	if (goldfish_tty_current_line_count == 0)