From: Willy Tarreau <w@1wt.eu>
Date: Wed, 14 Nov 2012 23:15:18 +0000 (+0100)
Subject: BUG: proxy: fix server name lookup in get_backend_server()
X-Git-Tag: v1.5-dev13~36
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4055a107a77c34a6a436ca1d7e5d901f81dcf573;p=thirdparty%2Fhaproxy.git

BUG: proxy: fix server name lookup in get_backend_server()

The lookup was broken by commit 050536d5. The server ID is
initialized to a negative value but unfortunately not all the
tests were converted. Thanks to Igor at owind for reporting it.
---

diff --git a/src/proxy.c b/src/proxy.c
index 914d97940d..9ccd25ad83 100644
--- a/src/proxy.c
+++ b/src/proxy.c
@@ -115,8 +115,8 @@ int get_backend_server(const char *bk_name, const char *sv_name,
 		return 0;
 
 	for (s = p->srv; s; s = s->next)
-		if ((sid && s->puid == sid) ||
-		    (!sid && strcmp(s->id, sv_name) == 0))
+		if ((sid >= 0 && s->puid == sid) ||
+		    (sid < 0 && strcmp(s->id, sv_name) == 0))
 			break;
 	*sv = s;
 	if (!s)