From: Peter Krempa <pkrempa@redhat.com>
Date: Mon, 20 Oct 2025 13:15:13 +0000 (+0200)
Subject: virNetDevVlanParse: Don't clear data on failure
X-Git-Tag: v11.9.0-rc1~42
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=40c4e4c847fd2a5cf7021a1464ad1300bb59b4d4;p=thirdparty%2Flibvirt.git

virNetDevVlanParse: Don't clear data on failure

Clearing the data on failure is pointless as it's still cleared when
other parts of the parser fail.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/conf/netdev_vlan_conf.c b/src/conf/netdev_vlan_conf.c
index 1ac66aec54..b98c4d92cf 100644
--- a/src/conf/netdev_vlan_conf.c
+++ b/src/conf/netdev_vlan_conf.c
@@ -122,8 +122,6 @@ virNetDevVlanParse(xmlNodePtr node, xmlXPathContextPtr ctxt, virNetDevVlan *def)
  cleanup:
     VIR_FREE(tagNodes);
     VIR_FREE(trunk);
-    if (ret < 0)
-        virNetDevVlanClear(def);
     return ret;
 }