From: Lennart Poettering <lennart@poettering.net>
Date: Mon, 17 Feb 2025 16:14:30 +0000 (+0100)
Subject: ptyfwd-tool: don't segfault if called without arguments
X-Git-Tag: v258-rc1~1283^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=40e22609e8dad046a984eaa84dba2a26b16d5a9c;p=thirdparty%2Fsystemd.git

ptyfwd-tool: don't segfault if called without arguments
---

diff --git a/src/ptyfwd/ptyfwd-tool.c b/src/ptyfwd/ptyfwd-tool.c
index c6ae362e3d3..f62a4dc767b 100644
--- a/src/ptyfwd/ptyfwd-tool.c
+++ b/src/ptyfwd/ptyfwd-tool.c
@@ -108,6 +108,9 @@ static int parse_argv(int argc, char *argv[]) {
                         assert_not_reached();
                 }
 
+        if (optind >= argc)
+                return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "Expected command line, refusing.");
+
         return 1;
 }
 
@@ -156,6 +159,8 @@ static int run(int argc, char *argv[]) {
         if (!l)
                 return log_oom();
 
+        assert_se(!strv_isempty(l));
+
         r = sd_event_default(&event);
         if (r < 0)
                 return log_error_errno(r, "Failed to get event loop: %m");