From: Volker Lendecke <vl@samba.org>
Date: Sun, 18 Aug 2024 09:29:46 +0000 (+0200)
Subject: libsmb: Simplify smb1cli_trans_recv()
X-Git-Tag: tdb-1.4.13~1364
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=40e2fdfc6bb4e991bc06a648ab6c0adc0ae6f040;p=thirdparty%2Fsamba.git

libsmb: Simplify smb1cli_trans_recv()

tevent_req_received() called below takes care of this

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/libcli/smb/smb1cli_trans.c b/libcli/smb/smb1cli_trans.c
index 99021ce2b47..02b2b2efb08 100644
--- a/libcli/smb/smb1cli_trans.c
+++ b/libcli/smb/smb1cli_trans.c
@@ -822,22 +822,16 @@ NTSTATUS smb1cli_trans_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx,
 	if (setup != NULL) {
 		*setup = talloc_move(mem_ctx, &state->rsetup);
 		*num_setup = state->num_rsetup;
-	} else {
-		TALLOC_FREE(state->rsetup);
 	}
 
 	if (param != NULL) {
 		*param = talloc_move(mem_ctx, &state->rparam.data);
 		*num_param = state->rparam.total;
-	} else {
-		TALLOC_FREE(state->rparam.data);
 	}
 
 	if (data != NULL) {
 		*data = talloc_move(mem_ctx, &state->rdata.data);
 		*num_data = state->rdata.total;
-	} else {
-		TALLOC_FREE(state->rdata.data);
 	}
 
 	status = state->status;