From: Alan T. DeKok <aland@freeradius.org>
Date: Wed, 2 Sep 2020 17:38:39 +0000 (-0400)
Subject: don't do shallow copy
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=412fd4ff2b36c7c247091846f2bd4fbbddc1a898;p=thirdparty%2Ffreeradius-server.git

don't do shallow copy

which makes the string have multiple parents, and causes
talloc complaints in xlat_eval
---

diff --git a/src/lib/util/value.c b/src/lib/util/value.c
index 69ed3b8d396..c9d21a03b4b 100644
--- a/src/lib/util/value.c
+++ b/src/lib/util/value.c
@@ -1740,7 +1740,7 @@ static inline int fr_value_box_cast_to_strvalue(TALLOC_CTX *ctx, fr_value_box_t
 		str = fr_value_box_asprint(ctx, src, '\0');
 		if (unlikely(!str)) return -1;
 
-		return fr_value_box_bstrdup_buffer_shallow(ctx, dst, dst_enumv, str, src->tainted);
+		return fr_value_box_bstrdup_buffer(ctx, dst, dst_enumv, str, src->tainted);
 	}
 	}
 }