From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Date: Tue, 25 Jul 2023 18:49:28 +0000 (-0700) Subject: [3.11] gh-62519: Make pgettext search plurals when translation is not found (GH-10711... X-Git-Tag: v3.11.5~143 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=41756e3960a38249b9e0076412ef5e08625a7acc;p=thirdparty%2FPython%2Fcpython.git [3.11] gh-62519: Make pgettext search plurals when translation is not found (GH-107118) (GH-107133) (cherry picked from commit b3c34e55c053846beb35f5e4253ef237b3494bd0) Co-authored-by: Tomas R Co-authored-by: Ɓukasz Langa --- diff --git a/Lib/gettext.py b/Lib/gettext.py index 6c5ec4e517f6..57f1a449c28a 100644 --- a/Lib/gettext.py +++ b/Lib/gettext.py @@ -444,10 +444,12 @@ class GNUTranslations(NullTranslations): missing = object() tmsg = self._catalog.get(ctxt_msg_id, missing) if tmsg is missing: - if self._fallback: - return self._fallback.pgettext(context, message) - return message - return tmsg + tmsg = self._catalog.get((ctxt_msg_id, self.plural(1)), missing) + if tmsg is not missing: + return tmsg + if self._fallback: + return self._fallback.pgettext(context, message) + return message def npgettext(self, context, msgid1, msgid2, n): ctxt_msg_id = self.CONTEXT % (context, msgid1) diff --git a/Lib/test/test_gettext.py b/Lib/test/test_gettext.py index 1608d1b18e98..7f7b51c19f35 100644 --- a/Lib/test/test_gettext.py +++ b/Lib/test/test_gettext.py @@ -329,6 +329,8 @@ class PluralFormsTestCase(GettextBaseTest): x = gettext.npgettext('With context', 'There is %s file', 'There are %s files', 2) eq(x, 'Hay %s ficheros (context)') + x = gettext.pgettext('With context', 'There is %s file') + eq(x, 'Hay %s fichero (context)') def test_plural_forms2(self): eq = self.assertEqual @@ -349,6 +351,8 @@ class PluralFormsTestCase(GettextBaseTest): x = t.npgettext('With context', 'There is %s file', 'There are %s files', 2) eq(x, 'Hay %s ficheros (context)') + x = gettext.pgettext('With context', 'There is %s file') + eq(x, 'Hay %s fichero (context)') # Examples from http://www.gnu.org/software/gettext/manual/gettext.html diff --git a/Misc/NEWS.d/next/Library/2023-07-23-12-26-23.gh-issue-62519.w8-81X.rst b/Misc/NEWS.d/next/Library/2023-07-23-12-26-23.gh-issue-62519.w8-81X.rst new file mode 100644 index 000000000000..96e2a3dcc24f --- /dev/null +++ b/Misc/NEWS.d/next/Library/2023-07-23-12-26-23.gh-issue-62519.w8-81X.rst @@ -0,0 +1,2 @@ +Make :func:`gettext.pgettext` search plural definitions when +translation is not found.