From: David Hankins <dhankins@isc.org>
Date: Tue, 8 Jan 2008 16:22:23 +0000 (+0000)
Subject: - A log message was introduced to clarify the situation where a failover
X-Git-Tag: v4_1_0a1~30
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=41d4652fd5ff17be6747fa1a9f0bea32f5c9d778;p=thirdparty%2Fdhcp.git

- A log message was introduced to clarify the situation where a failover
  'address' parameter (the server's local address) did not resolve to an
  IPv4 address.  [ISC-Bugs #15826]
---

diff --git a/RELNOTES b/RELNOTES
index 405548c22..d4585604a 100644
--- a/RELNOTES
+++ b/RELNOTES
@@ -94,6 +94,10 @@ suggested fixes to <dhcp-users@isc.org>.
 - A bug was fixed where the 'giaddr' may be used to find the client's subnet
   rather than its own 'ciaddr'.
 
+- A log message was introduced to clarify the situation where a failover
+  'address' parameter (the server's local address) did not resolve to an
+  IPv4 address.
+
 			Changes since 4.0.0b3
 
 - The reverse dns name for PTR updates on IPv6 addresses has been fixed to
diff --git a/server/failover.c b/server/failover.c
index c12938a28..b96cc855b 100644
--- a/server/failover.c
+++ b/server/failover.c
@@ -252,6 +252,9 @@ isc_result_t dhcp_failover_link_initiate (omapi_object_t *h)
 		}
 	} else {
 		if (ds.len != sizeof (struct in_addr)) {
+			log_error("failover peer %s: 'address' parameter "
+				  "fails to resolve to an IPv4 address",
+				  state->name);
 			data_string_forget (&ds, MDL);
 			dhcp_failover_link_dereference (&obj, MDL);
 			omapi_addr_list_dereference (&addrs, MDL);