From: Lennart Poettering <lennart@poettering.net>
Date: Fri, 1 Dec 2017 10:59:42 +0000 (+0100)
Subject: sd-bus: validate the message type (#7520)
X-Git-Tag: v236~85
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=41f23fe8562c53be76880cac0094584b0ca3b7ef;p=thirdparty%2Fsystemd.git

sd-bus: validate the message type (#7520)

Now that sd_bus_message_new() is public API, we should insist on valid
message types.
---

diff --git a/src/libsystemd/sd-bus/bus-message.c b/src/libsystemd/sd-bus/bus-message.c
index 23739292852..9d4ac8ee0fd 100644
--- a/src/libsystemd/sd-bus/bus-message.c
+++ b/src/libsystemd/sd-bus/bus-message.c
@@ -584,6 +584,7 @@ _public_ int sd_bus_message_new(
         assert_return(bus, -ENOTCONN);
         assert_return(bus->state != BUS_UNSET, -ENOTCONN);
         assert_return(m, -EINVAL);
+        assert_return(type < _SD_BUS_MESSAGE_TYPE_MAX, -EINVAL);
 
         t = malloc0(ALIGN(sizeof(sd_bus_message)) + sizeof(struct bus_header));
         if (!t)