From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Wed, 10 Mar 2021 03:23:07 +0000 (+1300)
Subject: ldb-samba: avoid VLA in dsdb match dns tombstone
X-Git-Tag: tevent-0.11.0~1343
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=421486044f6bd17bb66034c6097e23cfc3b6d054;p=thirdparty%2Fsamba.git

ldb-samba: avoid VLA in dsdb match dns tombstone

We don't need it (only 64 bytes) and, well, they annoy people.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/lib/ldb-samba/ldb_matching_rules.c b/lib/ldb-samba/ldb_matching_rules.c
index dc381854ab8..2c9d78fea8c 100644
--- a/lib/ldb-samba/ldb_matching_rules.c
+++ b/lib/ldb-samba/ldb_matching_rules.c
@@ -386,7 +386,7 @@ static int dsdb_match_for_dns_to_tombstone_time(struct ldb_context *ldb,
 		return LDB_ERR_INVALID_ATTRIBUTE_SYNTAX;
 	} else {
 		int error = 0;
-		char s[value_to_match->length+1];
+		char s[65];
 
 		memcpy(s, value_to_match->data, value_to_match->length);
 		s[value_to_match->length] = 0;