From: Yang Yingliang <yangyingliang@huawei.com>
Date: Tue, 30 Mar 2021 13:04:46 +0000 (+0200)
Subject: media: i2c: ov5648: fix wrong pointer passed to IS_ERR() and PTR_ERR()
X-Git-Tag: v5.18.3~407
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=424c087019d2895ca239b916889eb9e3715eab0b;p=thirdparty%2Fkernel%2Fstable.git

media: i2c: ov5648: fix wrong pointer passed to IS_ERR() and PTR_ERR()

[ Upstream commit a6dd5265c21c28d0a782befe41a97c347e78f22f ]

IS_ERR() and PTR_ERR() use wrong pointer, it should be
sensor->dovdd, fix it.

Fixes: e43ccb0a045f ("media: i2c: Add support for the OV5648 image sensor")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/drivers/media/i2c/ov5648.c b/drivers/media/i2c/ov5648.c
index 930ff6897044a..dfcd33e9ee136 100644
--- a/drivers/media/i2c/ov5648.c
+++ b/drivers/media/i2c/ov5648.c
@@ -2498,9 +2498,9 @@ static int ov5648_probe(struct i2c_client *client)
 
 	/* DOVDD: digital I/O */
 	sensor->dovdd = devm_regulator_get(dev, "dovdd");
-	if (IS_ERR(sensor->dvdd)) {
+	if (IS_ERR(sensor->dovdd)) {
 		dev_err(dev, "cannot get DOVDD (digital I/O) regulator\n");
-		ret = PTR_ERR(sensor->dvdd);
+		ret = PTR_ERR(sensor->dovdd);
 		goto error_endpoint;
 	}