From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Wed, 29 Apr 2020 13:14:06 +0000 (+0300)
Subject: submission-login: proxy - Change impossible code path to assert
X-Git-Tag: 2.3.13~683
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=42878bf253b47c54d312658923fe3e671fc1b30b;p=thirdparty%2Fdovecot%2Fcore.git

submission-login: proxy - Change impossible code path to assert
---

diff --git a/src/submission-login/submission-proxy.c b/src/submission-login/submission-proxy.c
index 4163b319ce..622b3470f7 100644
--- a/src/submission-login/submission-proxy.c
+++ b/src/submission-login/submission-proxy.c
@@ -431,13 +431,10 @@ int submission_proxy_parse_line(struct client *client, const char *line)
 	   So for now we'll just forward the error message. This
 	   shouldn't be a real problem since of course everyone will
 	   be using only Dovecot as their backend :) */
-	if ((status / 100) == 2) {
-		submission_proxy_error(client, AUTH_FAILED_MSG);
-	} else {
-		i_assert(subm_client->proxy_reply != NULL);
-		smtp_server_reply_submit(subm_client->proxy_reply);
-		subm_client->pending_auth = NULL;
-	}
+	i_assert((status / 100) != 2);
+	i_assert(subm_client->proxy_reply != NULL);
+	smtp_server_reply_submit(subm_client->proxy_reply);
+	subm_client->pending_auth = NULL;
 
 	if (client->set->auth_verbose) {
 		client_proxy_log_failure(client, text);