From: Ronnie Sahlberg Date: Mon, 23 Apr 2007 07:05:09 +0000 (+1000) Subject: add a comment that sometimes sending remote calls straight to the X-Git-Tag: tevent-0.9.20~348^2~2845^2~2 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=42971d65656e4676d708a95198780f86335e5885;p=thirdparty%2Fsamba.git add a comment that sometimes sending remote calls straight to the lmaster instead of what the nodes think is the dmaster (which might be stale) improve performance. (This used to be ctdb commit f535f79e6a2a6c6d07141b96e0b957fa93c684f4) --- diff --git a/ctdb/common/ctdb_call.c b/ctdb/common/ctdb_call.c index d81cca9e6f3..8db795d8897 100644 --- a/ctdb/common/ctdb_call.c +++ b/ctdb/common/ctdb_call.c @@ -716,6 +716,14 @@ struct ctdb_call_state *ctdb_daemon_call_send_remote(struct ctdb_db_context *ctd state->c->hdr.ctdb_version = CTDB_VERSION; state->c->hdr.operation = CTDB_REQ_CALL; state->c->hdr.destnode = header->dmaster; + /* + always sending the remote call straight to the lmaster + improved performance slightly in some tests. + worth investigating further in the future + state->c->hdr.destnode = ctdb_lmaster(ctdb_db->ctdb, &(call->key)); + */ + + state->c->hdr.srcnode = ctdb->vnn; /* this limits us to 16k outstanding messages - not unreasonable */ state->c->hdr.reqid = idr_get_new(ctdb->idr, state, 0xFFFF);