From: Ondřej Surý <ondrej@isc.org>
Date: Thu, 26 Oct 2023 07:14:10 +0000 (+0200)
Subject: Allowing changing Userspace-RCU variant only in developer mode
X-Git-Tag: v9.19.18~21^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=42d43aa0758513a45b54e0fd0bff4381fdc4d803;p=thirdparty%2Fbind9.git

Allowing changing Userspace-RCU variant only in developer mode

The Userspace-RCU variants other than membarrier is untested and at
least in QSBR case it's broken.  Allow changing the Userspace-RCU
variant only in the developer's mode.
---

diff --git a/configure.ac b/configure.ac
index cce13b499fe..4837cc549ba 100644
--- a/configure.ac
+++ b/configure.ac
@@ -207,7 +207,7 @@ AS_IF([test -z "$PKG_CONFIG"],
 # [pairwise: --with-liburcu=membarrier, --with-liburcu=qsbr, --with-liburcu=mb, --with-liburcu=signal, --with-liburcu=bp]
 AC_ARG_WITH([liburcu],
 	    [AS_HELP_STRING([--with-liburcu=FLAVOR],
-			     [Build with Userspace-RCU variant (membarrier|qsbr|mb|signal|bp) [default=membarrier]]))],
+			     [Build with Userspace-RCU variant (developer-only option) (membarrier|qsbr|mb|signal|bp) [default=membarrier]]))],
 	    [], [with_liburcu=membarrier])
 
 AC_MSG_CHECKING([liburcu flavor])
@@ -229,6 +229,9 @@ AS_CASE([$with_liburcu],
 	 AC_DEFINE([RCU_BP], [1], [Build with bulletproof Userspace-RCU flavor])],
 	[AC_MSG_ERROR([Invalid Userspace-RCU flavor picked])])
 
+AS_IF([test "$with_liburcu" != "membarrier" && test "$enable_developer" != "yes"],
+      [AC_MSG_ERROR([Changing Userspace-RCU variant is allowed only in developer mode])])
+
 AC_MSG_RESULT([$RCU_FLAVOR])
 
 #