From: Amitay Isaacs <amitay@gmail.com>
Date: Thu, 9 Nov 2017 05:37:15 +0000 (+1100)
Subject: ctdb-common: Avoid using void ** argument
X-Git-Tag: talloc-2.1.11~238
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=43145c88fe75d57ff66ea95d9db0ce503a2e8c03;p=thirdparty%2Fsamba.git

ctdb-common: Avoid using void ** argument

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
---

diff --git a/ctdb/common/sock_client.c b/ctdb/common/sock_client.c
index e5f993e085c..ced705042a4 100644
--- a/ctdb/common/sock_client.c
+++ b/ctdb/common/sock_client.c
@@ -311,7 +311,7 @@ static void sock_client_msg_reply(struct sock_client_context *sockc,
 }
 
 bool sock_client_msg_recv(struct tevent_req *req, int *perr,
-			  TALLOC_CTX *mem_ctx, void **reply)
+			  TALLOC_CTX *mem_ctx, void *reply)
 {
 	struct sock_client_msg_state *state = tevent_req_data(
 		req, struct sock_client_msg_state);
@@ -325,7 +325,7 @@ bool sock_client_msg_recv(struct tevent_req *req, int *perr,
 	}
 
 	if (reply != NULL) {
-		*reply = talloc_steal(mem_ctx, state->reply);
+		*(void **)reply = talloc_steal(mem_ctx, state->reply);
 	}
 
 	return true;
diff --git a/ctdb/common/sock_client.h b/ctdb/common/sock_client.h
index c640767c3a7..c5822a0ac01 100644
--- a/ctdb/common/sock_client.h
+++ b/ctdb/common/sock_client.h
@@ -124,6 +124,6 @@ struct tevent_req *sock_client_msg_send(TALLOC_CTX *mem_ctx,
  * @return true on success, false on failure
  */
 bool sock_client_msg_recv(struct tevent_req *req, int *perr,
-			  TALLOC_CTX *mem_ctx, void **reply);
+			  TALLOC_CTX *mem_ctx, void *reply);
 
 #endif /* __CTDB_SOCK_CLIENT_H__ */