From: George Kadianakis <desnacked@riseup.net>
Date: Tue, 18 Sep 2018 11:01:15 +0000 (+0300)
Subject: Fix minor memleak in edge-case of crypto_rsa.c function.
X-Git-Tag: tor-0.3.5.2-alpha~23^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=43324b0e4d9835ca7bab1d8e6bc4544a708b8ea4;p=thirdparty%2Ftor.git

Fix minor memleak in edge-case of crypto_rsa.c function.
---

diff --git a/src/lib/crypt_ops/crypto_rsa.c b/src/lib/crypt_ops/crypto_rsa.c
index c3c6db6c31..a510e12964 100644
--- a/src/lib/crypt_ops/crypto_rsa.c
+++ b/src/lib/crypt_ops/crypto_rsa.c
@@ -554,8 +554,10 @@ crypto_pk_read_private_key_from_filename(crypto_pk_t *env,
   char *buf = read_file_to_str(keyfile, 0, &st);
   if (!buf)
     return -1;
-  if (st.st_size > MAX_PRIVKEY_FILE_LEN)
+  if (st.st_size > MAX_PRIVKEY_FILE_LEN) {
+    tor_free(buf);
     return -1;
+  }
 
   int rv = crypto_pk_read_private_key_from_string(env, buf,
                                                   (ssize_t)st.st_size);