From: Andrew Bartlett <abartlet@samba.org>
Date: Mon, 27 Aug 2012 09:46:11 +0000 (+1000)
Subject: s4-dsdb: Remove double-free in update_keytab module
X-Git-Tag: samba-4.0.0beta7~8
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=43904cb4f5e775a5ba72553d1a59ffd30204a83d;p=thirdparty%2Fsamba.git

s4-dsdb: Remove double-free in update_keytab module
---

diff --git a/source4/dsdb/samdb/ldb_modules/update_keytab.c b/source4/dsdb/samdb/ldb_modules/update_keytab.c
index f07d9b2aadf..bec4a83abfc 100644
--- a/source4/dsdb/samdb/ldb_modules/update_keytab.c
+++ b/source4/dsdb/samdb/ldb_modules/update_keytab.c
@@ -109,14 +109,12 @@ static int add_modified(struct ldb_module *module, struct ldb_dn *dn, bool do_de
 	if (res->count != 1) {
 		/* if it's not a kerberosSecret then we don't have anything to update */
 		talloc_free(res);
-		talloc_free(filter);
 		return LDB_SUCCESS;
 	}
 
 	item = talloc(data->changed_dns? (void *)data->changed_dns: (void *)data, struct dn_list);
 	if (!item) {
 		talloc_free(res);
-		talloc_free(filter);
 		return ldb_oom(ldb);
 	}