From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Date: Mon, 27 Nov 2023 18:56:27 +0000 (+0100) Subject: [3.11] gh-112388: Fix an error that was causing the parser to try to overwrite tokeni... X-Git-Tag: v3.11.7~35 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=43b081bfc49173405576b8eba09a6ca86aac641b;p=thirdparty%2FPython%2Fcpython.git [3.11] gh-112388: Fix an error that was causing the parser to try to overwrite tokenizer errors (GH-112410) (#112467) gh-112388: Fix an error that was causing the parser to try to overwrite tokenizer errors (GH-112410) (cherry picked from commit 2c8b19174274c183eb652932871f60570123fe99) Signed-off-by: Pablo Galindo Co-authored-by: Pablo Galindo Salgado --- diff --git a/Lib/test/test_syntax.py b/Lib/test/test_syntax.py index 07049087cdac..bbd22eccb3e5 100644 --- a/Lib/test/test_syntax.py +++ b/Lib/test/test_syntax.py @@ -2152,6 +2152,7 @@ func( def test_invisible_characters(self): self._check_error('print\x17("Hello")', "invalid non-printable character") + self._check_error(b"with(0,,):\n\x01", "invalid non-printable character") def test_match_call_does_not_raise_syntax_error(self): code = """ diff --git a/Misc/NEWS.d/next/Core and Builtins/2023-11-25-22-58-49.gh-issue-112388.MU3cIM.rst b/Misc/NEWS.d/next/Core and Builtins/2023-11-25-22-58-49.gh-issue-112388.MU3cIM.rst new file mode 100644 index 000000000000..1c82be2febda --- /dev/null +++ b/Misc/NEWS.d/next/Core and Builtins/2023-11-25-22-58-49.gh-issue-112388.MU3cIM.rst @@ -0,0 +1,2 @@ +Fix an error that was causing the parser to try to overwrite tokenizer +errors. Patch by pablo Galindo diff --git a/Parser/pegen_errors.c b/Parser/pegen_errors.c index 005356110a43..29d5a6e179f3 100644 --- a/Parser/pegen_errors.c +++ b/Parser/pegen_errors.c @@ -212,6 +212,10 @@ exit: void * _PyPegen_raise_error(Parser *p, PyObject *errtype, const char *errmsg, ...) { + // Bail out if we already have an error set. + if (p->error_indicator && PyErr_Occurred()) { + return NULL; + } if (p->fill == 0) { va_list va; va_start(va, errmsg);