From: Nick Mathewson <nickm@torproject.org>
Date: Sun, 16 Apr 2017 15:52:31 +0000 (-0400)
Subject: Fix reference leak & handle leak in consensus_diff_worker_replyfn
X-Git-Tag: tor-0.3.1.1-alpha~152^2~6
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=43d683e0ad46b7914ef0e629dc7b953fcdd1f411;p=thirdparty%2Ftor.git

Fix reference leak & handle leak in consensus_diff_worker_replyfn

Found by previous test.
---

diff --git a/src/or/consdiffmgr.c b/src/or/consdiffmgr.c
index 240fe6e2da..1c9c2a9932 100644
--- a/src/or/consdiffmgr.c
+++ b/src/or/consdiffmgr.c
@@ -1058,6 +1058,7 @@ consensus_diff_worker_replyfn(void *work_)
                           job->bodylen_out);
     status = CDM_DIFF_PRESENT;
     handle = consensus_cache_entry_handle_new(ent);
+    consensus_cache_entry_decref(ent);
   } else {
     /* Failure! Nothing to do but complain */
     log_warn(LD_DIRSERV,
@@ -1069,6 +1070,9 @@ consensus_diff_worker_replyfn(void *work_)
 
   if (cache)
     cdm_diff_ht_set_status(flav, from_sha3, to_sha3, status, handle);
+  else
+    consensus_cache_entry_handle_free(handle);
+
   consensus_diff_worker_job_free(job);
 }