From: Qianfeng Rong Date: Fri, 29 Aug 2025 13:37:48 +0000 (+0800) Subject: dm-pcache: use int type to store negative error codes X-Git-Tag: v6.18-rc1~101^2~12 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4466dd3d719cca113308e8ae539adf7b3d68c985;p=thirdparty%2Flinux.git dm-pcache: use int type to store negative error codes Change the 'ret' variable from u32 to int to store negative error codes or zero returned by cache_kset_close(). Storing the negative error codes in unsigned type, doesn't cause an issue at runtime but it's ugly. Additionally, assigning negative error codes to unsigned type may trigger a GCC warning when the -Wsign-conversion flag is enabled. No effect on runtime. Signed-off-by: Qianfeng Rong Signed-off-by: Mikulas Patocka --- diff --git a/drivers/md/dm-pcache/cache_req.c b/drivers/md/dm-pcache/cache_req.c index bd5cace7de71..27f94c1fa968 100644 --- a/drivers/md/dm-pcache/cache_req.c +++ b/drivers/md/dm-pcache/cache_req.c @@ -805,7 +805,8 @@ err: int cache_flush(struct pcache_cache *cache) { struct pcache_cache_kset *kset; - u32 i, ret; + int ret; + u32 i; for (i = 0; i < cache->n_ksets; i++) { kset = get_kset(cache, i);