From: Michael Adam <obnox@samba.org>
Date: Fri, 20 Nov 2009 23:14:29 +0000 (+0100)
Subject: s3:fix endianness bug in dbwrap_change_int32_atomic() (bug #6901)
X-Git-Tag: samba-4.0.0alpha9~292
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=446ed18eb6eeec06b4f81aaf89f75db32472defb;p=thirdparty%2Fsamba.git

s3:fix endianness bug in dbwrap_change_int32_atomic() (bug #6901)

Michael
---

diff --git a/source3/lib/dbwrap_util.c b/source3/lib/dbwrap_util.c
index 96888a4fb0b..74b22655e2b 100644
--- a/source3/lib/dbwrap_util.c
+++ b/source3/lib/dbwrap_util.c
@@ -204,7 +204,7 @@ static NTSTATUS dbwrap_change_int32_atomic_action(struct db_context *db,
 {
 	struct db_record *rec;
 	int32_t val = -1;
-	TDB_DATA data;
+	int32_t v_store;
 	NTSTATUS ret;
 	struct dbwrap_change_int32_atomic_context *state;
 
@@ -227,10 +227,12 @@ static NTSTATUS dbwrap_change_int32_atomic_action(struct db_context *db,
 
 	val += state->change_val;
 
-	data.dsize = sizeof(val);
-	data.dptr = (uint8 *)&val;
+	SIVAL(&v_store, 0, val);
 
-	ret = rec->store(rec, data, TDB_REPLACE);
+	ret = rec->store(rec,
+			 make_tdb_data((const uint8_t *)&v_store,
+				       sizeof(v_store)),
+			 TDB_REPLACE);
 
 done:
 	TALLOC_FREE(rec);