From: Nikos Mavrogiannopoulos <nmav@gnutls.org>
Date: Mon, 8 Aug 2011 18:21:47 +0000 (+0200)
Subject: Prevent from loading twice the same module.
X-Git-Tag: gnutls_3_0_1~15^2~21
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=449101db1991ab5e7fdbfcb20fa8ff9e78d7f66e;p=thirdparty%2Fgnutls.git

Prevent from loading twice the same module.
---

diff --git a/lib/pkcs11.c b/lib/pkcs11.c
index 40d112f68a..8e33f8ab81 100644
--- a/lib/pkcs11.c
+++ b/lib/pkcs11.c
@@ -178,12 +178,28 @@ pkcs11_rescan_slots (void)
 static int
 pkcs11_add_module (const char *name, struct ck_function_list *module)
 {
+  struct ck_info info;
+  int i;
+
   if (active_providers >= MAX_PROVIDERS)
     {
       gnutls_assert ();
       return GNUTLS_E_CONSTRAINT_ERROR;
     }
 
+  /* initially check if this module is a duplicate */
+  memset(&info, 0, sizeof(info));
+  pkcs11_get_module_info (module, &info);
+  for (i=0;i<active_providers;i++)
+    {
+      /* already loaded, skip the rest */
+      if (memcmp(&info, &providers[i].info, sizeof(info)) == 0)
+        {
+          _gnutls_debug_log("%s is already loaded.\n", name);
+          return 0;
+        }
+    }
+
   active_providers++;
   providers[active_providers - 1].module = module;
 
@@ -215,10 +231,7 @@ pkcs11_add_module (const char *name, struct ck_function_list *module)
       goto fail;
     }
 
-  memset (&providers[active_providers - 1].info, 0,
-          sizeof (providers[active_providers - 1].info));
-  pkcs11_get_module_info (providers[active_providers - 1].module,
-                          &providers[active_providers - 1].info);
+  memcpy (&providers[active_providers - 1].info, &info, sizeof(info));
 
   _gnutls_debug_log ("p11: loaded provider '%s' with %d slots\n",
                      name, (int) providers[active_providers - 1].nslots);