From: Ned Deily Date: Sun, 23 Dec 2018 20:32:48 +0000 (-0500) Subject: bpo-35257: fix broken BLDSHARED - needs LDFLAGS too (GH-11297) X-Git-Tag: v3.8.0a1~214 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=44a3ee07e30e18d83e2730c093d8b0e930f0a06c;p=thirdparty%2FPython%2Fcpython.git bpo-35257: fix broken BLDSHARED - needs LDFLAGS too (GH-11297) `BLDSHARED` needs to have both `LDFLAGS` and `LDFLAGS_NODIST`, not just `LDFLAGS_NODIST`; `PY_CORE_LDFLAGS` provides both. For example, as it stands now with just `LDFLAGS_NODIST`, macOS universal builds are broken as the necessary `-arch` flags are no longer passed to the standard library extension module link step from `setup.py` resulting in extension modules being single architecture only. https://bugs.python.org/issue35257 --- diff --git a/Makefile.pre.in b/Makefile.pre.in index 04312e1be1c8..3c77a0e9fe32 100644 --- a/Makefile.pre.in +++ b/Makefile.pre.in @@ -153,7 +153,7 @@ CONFINCLUDEPY= $(CONFINCLUDEDIR)/python$(LDVERSION) SHLIB_SUFFIX= @SHLIB_SUFFIX@ EXT_SUFFIX= @EXT_SUFFIX@ LDSHARED= @LDSHARED@ $(PY_LDFLAGS) -BLDSHARED= @BLDSHARED@ $(PY_LDFLAGS_NODIST) +BLDSHARED= @BLDSHARED@ $(PY_CORE_LDFLAGS) LDCXXSHARED= @LDCXXSHARED@ DESTSHARED= $(BINLIBDEST)/lib-dynload