From: Volker Lendecke <vl@samba.org>
Date: Fri, 27 Jun 2008 09:13:07 +0000 (+0200)
Subject: Remove a strlen check that will never kick in
X-Git-Tag: samba-3.3.0pre1~730
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=44a9e5b713c25ff2cc7215635a516f25359b045b;p=thirdparty%2Fsamba.git

Remove a strlen check that will never kick in

strlen(str)<2 will be caught by the explicit tests for str[0] and str[1] in the
lines above this.

Jerry, please check!

Volker
---

diff --git a/source/nsswitch/libwbclient/wbc_sid.c b/source/nsswitch/libwbclient/wbc_sid.c
index b0909263fcb..eb115e12976 100644
--- a/source/nsswitch/libwbclient/wbc_sid.c
+++ b/source/nsswitch/libwbclient/wbc_sid.c
@@ -102,8 +102,7 @@ wbcErr wbcStringToSid(const char *str,
 
 	if (!str
 	    || (str[0]!='S' && str[0]!='s')
-	    || (str[1]!='-')
-	    || (strlen(str)<2))
+	    || (str[1]!='-'))
 	{
 		wbc_status = WBC_ERR_INVALID_PARAM;
 		BAIL_ON_WBC_ERROR(wbc_status);