From: AN Long <aisk@users.noreply.github.com>
Date: Mon, 2 Oct 2023 11:07:56 +0000 (+0800)
Subject: gh-108963: using random to generate unique string in sys.intern test (#109491)
X-Git-Tag: v3.13.0a1~187
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=44b1e4ea4842c6cdc1bedba7aaeb93f236b3ec08;p=thirdparty%2FPython%2Fcpython.git

gh-108963: using random to generate unique string in sys.intern test (#109491)
---

diff --git a/Lib/test/test_sys.py b/Lib/test/test_sys.py
index 16050171ad13..ae241d7a5027 100644
--- a/Lib/test/test_sys.py
+++ b/Lib/test/test_sys.py
@@ -5,6 +5,7 @@ import gc
 import locale
 import operator
 import os
+import random
 import struct
 import subprocess
 import sys
@@ -30,10 +31,6 @@ def requires_subinterpreters(meth):
                            'subinterpreters required')(meth)
 
 
-# count the number of test runs, used to create unique
-# strings to intern in test_intern()
-INTERN_NUMRUNS = 0
-
 DICT_KEY_STRUCT_FORMAT = 'n2BI2n'
 
 class DisplayHookTest(unittest.TestCase):
@@ -696,10 +693,8 @@ class SysModuleTest(unittest.TestCase):
         self.assertEqual(sys.__stdout__.encoding, sys.__stderr__.encoding)
 
     def test_intern(self):
-        global INTERN_NUMRUNS
-        INTERN_NUMRUNS += 1
         self.assertRaises(TypeError, sys.intern)
-        s = "never interned before" + str(INTERN_NUMRUNS)
+        s = "never interned before" + str(random.randrange(0, 10**9))
         self.assertTrue(sys.intern(s) is s)
         s2 = s.swapcase().swapcase()
         self.assertTrue(sys.intern(s2) is s)
@@ -717,9 +712,7 @@ class SysModuleTest(unittest.TestCase):
 
     @requires_subinterpreters
     def test_subinterp_intern_dynamically_allocated(self):
-        global INTERN_NUMRUNS
-        INTERN_NUMRUNS += 1
-        s = "never interned before" + str(INTERN_NUMRUNS)
+        s = "never interned before" + str(random.randrange(0, 10**9))
         t = sys.intern(s)
         self.assertIs(t, s)