From: Evan You <yyx990803@gmail.com>
Date: Mon, 24 Sep 2018 00:30:26 +0000 (-0400)
Subject: feat: renderError
X-Git-Tag: v3.0.0-alpha.0~1206
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=44d1a8efcbf7513a0043bb4521487f633f248016;p=thirdparty%2Fvuejs%2Fcore.git

feat: renderError
---

diff --git a/packages/core/src/component.ts b/packages/core/src/component.ts
index 982faa8583..3ac07bde4f 100644
--- a/packages/core/src/component.ts
+++ b/packages/core/src/component.ts
@@ -34,6 +34,7 @@ export interface MountedComponent<D = Data, P = Data> extends Component {
   $options: ComponentOptions<D, P>
 
   render: RenderFunction<P>
+  renderError?: (e: Error) => any
   data?(): Partial<D>
   beforeCreate?(): void
   created?(): void
diff --git a/packages/core/src/componentUtils.ts b/packages/core/src/componentUtils.ts
index 0a40911939..093e580081 100644
--- a/packages/core/src/componentUtils.ts
+++ b/packages/core/src/componentUtils.ts
@@ -14,6 +14,7 @@ import {
 import { initializeWatch, teardownWatch } from './componentWatch'
 import { Data, ComponentOptions } from './componentOptions'
 import { createRenderProxy } from './componentProxy'
+import { handleError, ErrorTypes } from './errorHandling'
 
 export function createComponentInstance(
   vnode: VNode,
@@ -53,11 +54,24 @@ export function createComponentInstance(
 }
 
 export function renderInstanceRoot(instance: MountedComponent) {
-  // TODO handle render error
-  return normalizeComponentRoot(
-    instance.render.call(instance.$proxy, instance.$props, instance.$slots),
-    instance.$parentVNode
-  )
+  let vnode
+  try {
+    vnode = instance.render.call(
+      instance.$proxy,
+      instance.$props,
+      instance.$slots
+    )
+  } catch (e1) {
+    handleError(e1, instance, ErrorTypes.RENDER)
+    if (__DEV__ && instance.renderError) {
+      try {
+        vnode = instance.renderError.call(instance.$proxy, e1)
+      } catch (e2) {
+        handleError(e2, instance, ErrorTypes.RENDER_ERROR)
+      }
+    }
+  }
+  return normalizeComponentRoot(vnode, instance.$parentVNode)
 }
 
 export function teardownComponentInstance(instance: MountedComponent) {
diff --git a/packages/core/src/errorHandling.ts b/packages/core/src/errorHandling.ts
index 7714bcf45f..8a59d2ab0d 100644
--- a/packages/core/src/errorHandling.ts
+++ b/packages/core/src/errorHandling.ts
@@ -2,9 +2,10 @@ import { MountedComponent } from './component'
 
 export const enum ErrorTypes {
   LIFECYCLE = 1,
-  RENDER = 2,
-  NATIVE_EVENT_HANDLER = 3,
-  COMPONENT_EVENT_HANDLER = 4
+  RENDER,
+  RENDER_ERROR,
+  NATIVE_EVENT_HANDLER,
+  COMPONENT_EVENT_HANDLER
 }
 
 const globalHandlers: Function[] = []
@@ -19,8 +20,7 @@ export function globalHandleError(handler: () => void) {
 export function handleError(
   err: Error,
   instance: MountedComponent,
-  type: ErrorTypes,
-  code: number
+  type: ErrorTypes
 ) {
   // TODO
 }