From: Martin Willi <martin@revosec.ch>
Date: Mon, 9 Jan 2012 12:41:35 +0000 (+0100)
Subject: Fix error handling if no PSK found for main mode
X-Git-Tag: 5.0.0~338^2~9^2~88
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=44dcd5944ab878cb5bbbec6aa79d5d99b109d33f;p=thirdparty%2Fstrongswan.git

Fix error handling if no PSK found for main mode
---

diff --git a/src/libcharon/sa/ikev1/tasks/main_mode.c b/src/libcharon/sa/ikev1/tasks/main_mode.c
index 3c0a2520e7..2fc06ca1a6 100644
--- a/src/libcharon/sa/ikev1/tasks/main_mode.c
+++ b/src/libcharon/sa/ikev1/tasks/main_mode.c
@@ -799,11 +799,11 @@ static shared_key_t *lookup_shared_key(private_main_mode_t *this)
 		{
 			shared_key = lib->credmgr->get_shared(lib->credmgr, SHARED_IKE,
 												  my_id, other_id);
-		}
-		else
-		{
-			DBG1(DBG_IKE, "no shared key found for '%Y'[%H] - '%Y'[%H]",
-				 my_id, me, other_id, other);
+			if (!shared_key)
+			{
+				DBG1(DBG_IKE, "no shared key found for '%Y'[%H] - '%Y'[%H]",
+					 my_id, me, other_id, other);
+			}
 		}
 	}
 	else
@@ -862,6 +862,10 @@ static bool derive_keys(private_main_mode_t *this, chunk_t nonce_i,
 		case AUTH_XAUTH_INIT_PSK:
 		case AUTH_XAUTH_RESP_PSK:
 			shared_key = lookup_shared_key(this);
+			if (!shared_key)
+			{
+				return FALSE;
+			}
 			break;
 		default:
 			break;