From: Jeremy Allison <jra@samba.org>
Date: Mon, 4 Jun 2007 23:31:34 +0000 (+0000)
Subject: r23347: Fix Coverity 363. Dead code elimination.
X-Git-Tag: samba-misc-tags/initial-v3-0-unstable~269
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4524ee2dbcd5c1c66085032de67c6d083f91cb8a;p=thirdparty%2Fsamba.git

r23347: Fix Coverity 363. Dead code elimination.
Jeremy.
---

diff --git a/source/libsmb/clifile.c b/source/libsmb/clifile.c
index 61c4347b5bc..64b3e652cf9 100644
--- a/source/libsmb/clifile.c
+++ b/source/libsmb/clifile.c
@@ -1692,13 +1692,9 @@ static BOOL cli_get_ea_list(struct cli_state *cli,
 		goto out;
 	}
 
-	if (num_eas) {
-		ea_list = TALLOC_ARRAY(ctx, struct ea_struct, num_eas);
-		if (!ea_list) {
-			goto out;
-		}
-	} else {
-		ea_list = NULL;
+	ea_list = TALLOC_ARRAY(ctx, struct ea_struct, num_eas);
+	if (!ea_list) {
+		goto out;
 	}
 
 	ea_size = (size_t)IVAL(rdata,0);