From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Mon, 10 Jul 2023 01:27:56 +0000 (+1200)
Subject: smbXcli: Remove call to utf16_len_n()
X-Git-Tag: tevent-0.16.0~1178
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=45ef3ab99c3b49f084696c4b17d811e499572d91;p=thirdparty%2Fsamba.git

smbXcli: Remove call to utf16_len_n()

This code was probably intended to refer to ‘blob1’ rather than to
‘blob2’. As it is, it fails to achieve anything.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/libcli/smb/smbXcli_base.c b/libcli/smb/smbXcli_base.c
index fe422eb83fa..88e2ccad9a6 100644
--- a/libcli/smb/smbXcli_base.c
+++ b/libcli/smb/smbXcli_base.c
@@ -4638,10 +4638,6 @@ static void smbXcli_negprot_smb1_done(struct tevent_req *subreq)
 			if (blob2.length > 0) {
 				size_t len;
 
-				len = utf16_len_n(blob1.data,
-						  blob1.length);
-				blob1.length = len;
-
 				ok = convert_string_talloc(state,
 							   CH_UTF16LE,
 							   CH_UNIX,