From: Evan You Date: Tue, 26 Nov 2019 23:06:55 +0000 (-0500) Subject: test: improve events module test stability X-Git-Tag: v3.0.0-alpha.0~145 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=460b053f7486c2cbde6ecc1f237229376127653a;p=thirdparty%2Fvuejs%2Fcore.git test: improve events module test stability --- diff --git a/packages/runtime-dom/__tests__/modules/events.spec.ts b/packages/runtime-dom/__tests__/modules/events.spec.ts index 992da4a716..8d6cb9de3a 100644 --- a/packages/runtime-dom/__tests__/modules/events.spec.ts +++ b/packages/runtime-dom/__tests__/modules/events.spec.ts @@ -12,6 +12,7 @@ describe(`events`, () => { el.dispatchEvent(event) await nextTick() el.dispatchEvent(event) + await nextTick() expect(fn).toHaveBeenCalledTimes(3) }) @@ -27,28 +28,31 @@ describe(`events`, () => { el.dispatchEvent(event) await nextTick() el.dispatchEvent(event) + await nextTick() expect(prevFn).toHaveBeenCalledTimes(1) expect(nextFn).toHaveBeenCalledTimes(2) }) - it('should support multiple event handlers', () => { + it('should support multiple event handlers', async () => { const el = document.createElement('div') const event = new Event('click') const fn1 = jest.fn() const fn2 = jest.fn() patchEvent(el, 'click', null, [fn1, fn2], null) el.dispatchEvent(event) + await nextTick() expect(fn1).toHaveBeenCalledTimes(1) expect(fn2).toHaveBeenCalledTimes(1) }) - it('should unassign event handler', () => { + it('should unassign event handler', async () => { const el = document.createElement('div') const event = new Event('click') const fn = jest.fn() patchEvent(el, 'click', null, fn, null) patchEvent(el, 'click', fn, null, null) el.dispatchEvent(event) + await nextTick() expect(fn).not.toHaveBeenCalled() }) @@ -66,6 +70,7 @@ describe(`events`, () => { el.dispatchEvent(event) await nextTick() el.dispatchEvent(event) + await nextTick() expect(fn).toHaveBeenCalledTimes(1) }) @@ -85,6 +90,7 @@ describe(`events`, () => { el.dispatchEvent(event) await nextTick() el.dispatchEvent(event) + await nextTick() expect(prevFn).not.toHaveBeenCalled() expect(nextFn).toHaveBeenCalledTimes(1) }) @@ -104,6 +110,7 @@ describe(`events`, () => { el.dispatchEvent(event) await nextTick() el.dispatchEvent(event) + await nextTick() expect(fn).not.toHaveBeenCalled() }) })