From: Gregory P. Smith <greg@mad-scientist.com>
Date: Sat, 15 Mar 2008 06:05:36 +0000 (+0000)
Subject: Fix an apparent typo.  This test of the readonly boolean should have been != 0
X-Git-Tag: v3.0a4~164
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=462187540764e3bcc2324fb0d51315f5c28ed088;p=thirdparty%2FPython%2Fcpython.git

Fix an apparent typo.  This test of the readonly boolean should have been != 0
rather than >= 0.  This change means the PyBUF_LOCK flag to the buffer api
works on immutable bytes objects as one would expect.
---

diff --git a/Objects/abstract.c b/Objects/abstract.c
index 655a52a0bece..c0298a8aa39a 100644
--- a/Objects/abstract.c
+++ b/Objects/abstract.c
@@ -673,7 +673,7 @@ PyBuffer_FillInfo(Py_buffer *view, void *buf, Py_ssize_t len,
 {
 	if (view == NULL) return 0;
 	if (((flags & PyBUF_LOCK) == PyBUF_LOCK) &&
-	    readonly >= 0) {
+	    readonly != 0) {
 		PyErr_SetString(PyExc_BufferError,
 				"Cannot lock this object.");
 		return -1;