From: Volker Lendecke <vl@samba.org>
Date: Thu, 9 Nov 2023 11:25:32 +0000 (+0100)
Subject: smbd: Remove a NULL check that became obsolete
X-Git-Tag: talloc-2.4.2~732
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=46372997a09c6c4cc213941d3d510cfebf500855;p=thirdparty%2Fsamba.git

smbd: Remove a NULL check that became obsolete

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/smbd/dosmode.c b/source3/smbd/dosmode.c
index 229a85a9171..41241fd2bfc 100644
--- a/source3/smbd/dosmode.c
+++ b/source3/smbd/dosmode.c
@@ -686,16 +686,6 @@ uint32_t fdos_mode(struct files_struct *fsp)
 	uint32_t result = 0;
 	NTSTATUS status = NT_STATUS_OK;
 
-	if (fsp == NULL) {
-		/*
-		 * The pathological case where a caller does
-		 * fdos_mode(smb_fname->fsp) passing a pathref fsp. But as
-		 * smb_fname points at a symlink in POSIX context smb_fname->fsp
-		 * is NULL.
-		 */
-		return FILE_ATTRIBUTE_NORMAL;
-	}
-
 	DBG_DEBUG("%s\n", fsp_str_dbg(fsp));
 
 	if (fsp->fake_file_handle != NULL) {