From: Volker Lendecke <vl@samba.org>
Date: Wed, 26 Sep 2012 21:53:59 +0000 (-0700)
Subject: s3: Fix rejecting mkdir on read-only shares
X-Git-Tag: talloc-2.0.8~101
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4666dec4160d09a6d87349c5521fe5751eb5e764;p=thirdparty%2Fsamba.git

s3: Fix rejecting mkdir on read-only shares

Signed-off-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index 10c855c225f..40a64115e10 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -2815,7 +2815,7 @@ static NTSTATUS mkdir_internal(connection_struct *conn,
 	bool need_re_stat = false;
 	uint32_t access_mask = SEC_DIR_ADD_SUBDIR;
 
-	if(access_mask & ~(conn->share_access)) {
+	if (!CAN_WRITE(conn) || (access_mask & ~(conn->share_access))) {
 		DEBUG(5,("mkdir_internal: failing share access "
 			 "%s\n", lp_servicename(talloc_tos(), SNUM(conn))));
 		return NT_STATUS_ACCESS_DENIED;