From: Frantisek Sumsal <frantisek@sumsal.cz>
Date: Thu, 19 Oct 2023 14:23:28 +0000 (+0200)
Subject: test: add coverage for #29610
X-Git-Tag: v255-rc1~194^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4701425dd58f90f8bd51cc215916f7d7828e547f;p=thirdparty%2Fsystemd.git

test: add coverage for #29610

As reproducing it is actually pretty easy, with the benefit of hindsight:

~# systemd-run -P -p MountImages="/this/should/definitely/not/exist.img:/run/img2\:3:nosuid" false
Running as unit: run-u42.service
free(): double free detected in tcache 2
---

diff --git a/test/units/testsuite-50.sh b/test/units/testsuite-50.sh
index 4142e1ebbc8..1a379ee061c 100755
--- a/test/units/testsuite-50.sh
+++ b/test/units/testsuite-50.sh
@@ -674,4 +674,11 @@ if command -v mksquashfs >/dev/null 2>&1; then
     (! test -f /tmp/test-50-confext/etc/waldo )
 fi
 
+# Sneak in a couple of expected-to-fail invocations to cover
+# https://github.com/systemd/systemd/issues/29610
+(! systemd-run -P -p MountImages="/this/should/definitely/not/exist.img:/run/img2\:3:nosuid" false)
+(! systemd-run -P -p ExtensionImages="/this/should/definitely/not/exist.img" false)
+(! systemd-run -P -p RootImage="/this/should/definitely/not/exist.img" false)
+(! systemd-run -P -p ExtensionDirectories="/foo/bar /foo/baz" false)
+
 touch /testok