From: Takashi Iwai Date: Sun, 12 Apr 2020 08:13:29 +0000 (+0200) Subject: ALSA: usb-audio: Don't override ignore_ctl_error value from the map X-Git-Tag: v4.14.177~79 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=47019436aecd6641cf6bc47277e11234180217f0;p=thirdparty%2Fkernel%2Fstable.git ALSA: usb-audio: Don't override ignore_ctl_error value from the map commit 3507245b82b4362dc9721cbc328644905a3efa22 upstream. The mapping table may contain also ignore_ctl_error flag for devices that are known to behave wild. Since this flag always writes the card's own ignore_ctl_error flag, it overrides the value already set by the module option, so it doesn't follow user's expectation. Let's fix the code not to clear the flag that has been set by user. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206873 Cc: Link: https://lore.kernel.org/r/20200412081331.4742-3-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c index e6e4c3b9d9d3f..7b75208d5cea9 100644 --- a/sound/usb/mixer.c +++ b/sound/usb/mixer.c @@ -2342,7 +2342,7 @@ static int snd_usb_mixer_controls(struct usb_mixer_interface *mixer) if (map->id == state.chip->usb_id) { state.map = map->map; state.selector_map = map->selector_map; - mixer->ignore_ctl_error = map->ignore_ctl_error; + mixer->ignore_ctl_error |= map->ignore_ctl_error; break; } }