From: Martin Schwenke <mschwenke@ddn.com>
Date: Fri, 5 Jul 2024 01:47:56 +0000 (+1000)
Subject: ctdb-tests: Initialise return code file
X-Git-Tag: tdb-1.4.13~1337
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=47540012009aecbb0df90c158bcfb64afc135913;p=thirdparty%2Fsamba.git

ctdb-tests: Initialise return code file

The output file is initialised, so doesn't need to be created on
success.  Treat the return code file the same way.

Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
---

diff --git a/ctdb/tests/UNIT/eventscripts/scripts/60.nfs.sh b/ctdb/tests/UNIT/eventscripts/scripts/60.nfs.sh
index fa9e2e0febe..163ef5f59ca 100644
--- a/ctdb/tests/UNIT/eventscripts/scripts/60.nfs.sh
+++ b/ctdb/tests/UNIT/eventscripts/scripts/60.nfs.sh
@@ -298,6 +298,7 @@ rpc_set_service_failure_response()
 	_out="${CTDB_TEST_TMP_DIR}/rpc_failure_output"
 	: >"$_out"
 	_rc_file="${CTDB_TEST_TMP_DIR}/rpc_result"
+	echo 0 >"$_rc_file"
 
 	(
 		# Subshell to restrict scope variables...
@@ -333,7 +334,6 @@ rpc_set_service_failure_response()
 
 		if [ "$_numfails" -eq -1 ]; then
 			_unhealthy=false
-			echo 0 >"$_rc_file"
 			rpc_failure \
 				"WARNING: statistics changed but" \
 				"$_rpc_service" \
@@ -350,7 +350,6 @@ rpc_set_service_failure_response()
 				>"$_out"
 		else
 			_unhealthy=false
-			echo 0 >"$_rc_file"
 		fi
 
 		if [ $restart_every -gt 0 ] &&