From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Date: Thu, 4 Oct 2018 19:26:33 +0000 (-0700) Subject: bpo-34871: inspect: Don't pollute sys.modules (GH-9696) (#9701) X-Git-Tag: v3.7.1rc2~33 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=476c294f260ebe1b44157a168c3dfa4a43724ce3;p=thirdparty%2FPython%2Fcpython.git bpo-34871: inspect: Don't pollute sys.modules (GH-9696) (#9701) https://bugs.python.org/issue34871 (cherry picked from commit 6f85b826b527e240551613aeec3118a5469e3a33) Co-authored-by: INADA Naoki --- diff --git a/Lib/inspect.py b/Lib/inspect.py index 4482b8ea29d5..b5d583ccfd1b 100644 --- a/Lib/inspect.py +++ b/Lib/inspect.py @@ -1988,7 +1988,7 @@ def _signature_fromstr(cls, obj, s, skip_bound_arg=True): module = sys.modules.get(module_name, None) if module: module_dict = module.__dict__ - sys_module_dict = sys.modules + sys_module_dict = sys.modules.copy() def parse_name(node): assert isinstance(node, ast.arg) diff --git a/Misc/NEWS.d/next/Library/2018-10-04-18-46-54.bpo-34871.t3X-dB.rst b/Misc/NEWS.d/next/Library/2018-10-04-18-46-54.bpo-34871.t3X-dB.rst new file mode 100644 index 000000000000..8cff15671ce5 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2018-10-04-18-46-54.bpo-34871.t3X-dB.rst @@ -0,0 +1,2 @@ +Fix inspect module polluted ``sys.modules`` when parsing +``__text_signature__`` of callable.