From: Christian Heimes Date: Mon, 10 Sep 2012 14:57:36 +0000 (+0200) Subject: Fixed memory leak in error branch of object_repr which may leak a reference to mod... X-Git-Tag: v2.7.4rc1~576 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=47770ed914606282b5e251d03a17b90795ec347a;p=thirdparty%2FPython%2Fcpython.git Fixed memory leak in error branch of object_repr which may leak a reference to mod when type_name returns NULL. CID 715371 --- diff --git a/Objects/typeobject.c b/Objects/typeobject.c index e527eed79245..339e69ec4b97 100644 --- a/Objects/typeobject.c +++ b/Objects/typeobject.c @@ -2984,8 +2984,10 @@ object_repr(PyObject *self) mod = NULL; } name = type_name(type, NULL); - if (name == NULL) + if (name == NULL) { + Py_XDECREF(mod); return NULL; + } if (mod != NULL && strcmp(PyString_AS_STRING(mod), "__builtin__")) rtn = PyString_FromFormat("<%s.%s object at %p>", PyString_AS_STRING(mod),