From: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
Date: Sun, 29 Nov 2020 16:47:35 +0000 (+0200)
Subject: libkmod: kmod_builtin_get_modinfo: free modinfo on error
X-Git-Tag: v28~11
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=47807c4cfa5ffe1e5da27e3d3056d9b47ba998c5;p=thirdparty%2Fkmod.git

libkmod: kmod_builtin_get_modinfo: free modinfo on error

The function allocates array but on building it if get_string()
fails it returns the error leaving the array allocated. The caller
does not care about it in error case either.

Free it to fix memory leak.

Signed-off-by: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
---

diff --git a/libkmod/libkmod-builtin.c b/libkmod/libkmod-builtin.c
index aaec5ddb..fc9a3764 100644
--- a/libkmod/libkmod-builtin.c
+++ b/libkmod/libkmod-builtin.c
@@ -314,6 +314,7 @@ ssize_t kmod_builtin_get_modinfo(struct kmod_ctx *ctx, const char *modname,
 		offset = get_string(iter, pos, &line, &linesz);
 		if (offset <= 0) {
 			count = (offset) ? -errno : -EOF;
+			free(*modinfo);
 			goto fail;
 		}