From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Tue, 12 Oct 2021 07:19:09 +0000 (-0700)
Subject: bpo-45401: Fix a resource warning in test_logging (GH-28864) (GH-28872)
X-Git-Tag: v3.10.1~187
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=47a50fe16f9f074daaaa3e6aa85e76502955ed40;p=thirdparty%2FPython%2Fcpython.git

bpo-45401: Fix a resource warning in test_logging (GH-28864) (GH-28872)

(cherry picked from commit 15188b115a2da815556053372c912a81a74be43b)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
---

diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py
index 1a5f8b60f5cc..93f6e5f85a0a 100644
--- a/Lib/test/test_logging.py
+++ b/Lib/test/test_logging.py
@@ -5298,6 +5298,7 @@ class TimedRotatingFileHandlerTest(BaseFileTest):
         time.sleep(1.1)    # a little over a second ...
         r = logging.makeLogRecord({'msg': 'testing - device file'})
         self.assertFalse(fh.shouldRollover(r))
+        fh.close()
 
     # other test methods added below
     def test_rollover(self):