From: Nikolay Kuratov Date: Mon, 16 Dec 2024 11:19:23 +0000 (+0300) Subject: tracing/kprobes: Skip symbol counting logic for module symbols in create_local_trace_... X-Git-Tag: v5.10.232~14 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=47b341f714e68d36786b61b760379506a1a2d484;p=thirdparty%2Fkernel%2Fstable.git tracing/kprobes: Skip symbol counting logic for module symbols in create_local_trace_kprobe() commit b022f0c7e404 ("tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols") avoids checking number_of_same_symbols() for module symbol in __trace_kprobe_create(), but create_local_trace_kprobe() should avoid this check too. Doing this check leads to ENOENT for module_name:symbol_name constructions passed over perf_event_open. No bug in newer kernels as it was fixed more generally by commit 9d8616034f16 ("tracing/kprobes: Add symbol counting check when module loads") Link: https://lore.kernel.org/linux-trace-kernel/20240705161030.b3ddb33a8167013b9b1da202@kernel.org Fixes: b022f0c7e404 ("tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols") Signed-off-by: Nikolay Kuratov Signed-off-by: Greg Kroah-Hartman --- diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index ae059345ddf4c..164779c6d1333 100644 --- a/kernel/trace/trace_kprobe.c +++ b/kernel/trace/trace_kprobe.c @@ -1872,7 +1872,7 @@ create_local_trace_kprobe(char *func, void *addr, unsigned long offs, int ret; char *event; - if (func) { + if (func && !strchr(func, ':')) { unsigned int count; count = number_of_same_symbols(func);