From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Tue, 16 May 2023 00:04:49 +0000 (+1200)
Subject: selftest: Report better error message if environment is unknown
X-Git-Tag: talloc-2.4.1~589
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=480060ecd34472cce41b1322a2ac35c32889ca74;p=thirdparty%2Fsamba.git

selftest: Report better error message if environment is unknown

Now we get the error “environment [...] is unknown” rather than “samba
can't start up known environment”.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/selftest/target/Samba.pm b/selftest/target/Samba.pm
index 29a612aab8b..334665a6ff2 100644
--- a/selftest/target/Samba.pm
+++ b/selftest/target/Samba.pm
@@ -129,7 +129,7 @@ sub setup_env($$$)
 	}
 	if ($env eq "UNKNOWN") {
 		warn("unknown environment '$envname'");
-		return undef;
+		return $env;
 	}
 
 	$target->{vars}->{$envname} = $env;